Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): logger shouldLog checking lower log level #1483

Merged
merged 2 commits into from
Dec 14, 2022
Merged

fix(core): logger shouldLog checking lower log level #1483

merged 2 commits into from
Dec 14, 2022

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Dec 14, 2022 •
edited
Loading

Debug = 0
Warning = 2

With level as Warning, logger.ShouldLog(Debug) returned true, it should return false
Debug <= Warning is true (wrong)
Debug >= Warning is false (good)

@Codelax Codelax added the bug Something isn't working label Dec 14, 2022
@Codelax Codelax self-assigned this Dec 14, 2022
@Codelax Codelax merged commit 0597224 into scaleway:master Dec 14, 2022
@Codelax Codelax deleted the fix/shouldlog-compare-verbosity branch December 14, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quantumsheep quantumsheep quantumsheep approved these changes

Assignees

@Codelax Codelax

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Codelax @quantumsheep