Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add strcase lib #229

Merged
merged 3 commits into from
Nov 12, 2019
Merged

Conversation

kindermoumoute
Copy link
Contributor

  • ToPublicGoName: convert a field name to a valid public Go name
  • ToPrivateGoName: convert a field name to a valid private Go name
  • ToBashArg: convert a field name to a valid bash argument

- ToPublicGoName: convert a field name to a valid public Go name
- ToPrivateGoName: convert a field name to a valid private Go name
- ToBashArg: convert a field name to a valid bash argument
QuentinBrosse
QuentinBrosse previously approved these changes Nov 7, 2019
Copy link
Contributor

@QuentinBrosse QuentinBrosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits

strcase/bash_arg.go Outdated Show resolved Hide resolved
strcase/goname.go Outdated Show resolved Hide resolved
strcase/goname.go Outdated Show resolved Hide resolved
Copy link
Contributor

@QuentinBrosse QuentinBrosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kindermoumoute kindermoumoute merged commit f29cb8a into scaleway:master Nov 12, 2019
@kindermoumoute kindermoumoute deleted the strcase branch November 12, 2019 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants