feat(k8s): add WaitForPool & WaitForClusterPools helper methods

[debovema]

Requirement of https://github.com/terraform-providers/terraform-provider-scaleway/pull/393

[Sh4d1]

Okay, so I have a different approach:

• WaitForNodesReadyRequest with either a ClusterID or a PoolID and a Region
• WaitForNodesReady which will:
  • check the status of the pool and the targetsize == current node count if poolID is not empty
  • chech the status of each pool and current node count of cluster == sum of pool target size is clusterID is not empty
  • fail if both are empty

@QuentinBrosse @jerome-quere any thoughts?

[QuentinBrosse]

@Sh4d1

* `WaitForNodesReadyRequest` with either a `ClusterID` or a `PoolID` and a `Region`

I prefer 2 methods (eg. WaitForCluserNodesReady and WaitForPoolNodesReady)

[debovema]

@Sh4d1 @QuentinBrosse : thanks for your comments. I will try to have a look asap.

[debovema]

WaitForCluserNodesReady

just to be sure, WaitForClusterNodesReadywould just call WaitForPoolNodesReady for all the pools of the cluster ?

[Sh4d1]

@debovema Since the implementation of pool ready will be to check if target size == current_node_count and the status == ready, I guess you can

• either loop through each pool and call this method
• or check that each pool is ready and current_node_counf of cluster == sum of target size for each pool

I think both implementation are quite the same in term of performance. Maybe opt for the first one since you can in fact reuse the WaitForPoolNodesReady :)

[debovema]

• WaitForNodesReadyRequest with either a ClusterID or a PoolID and a Region

For this one, I am not yet as familiar as you with the Scaleway API but why do we need to provide a PoolID and a Region in the request ? It means that a PoolID is not unique across region right ? But what if we provide directly a *k8s.Pool parameter in the request ?

[Sh4d1]

This method won't be implemented no?
I guess the cleaner way is to pass the clusterID to WaitForClusterNodesReady and a poolID to WaitForPoolNodesReady. (Since you only need the ID anyway I think)

[Sh4d1]

LGTM

[loicbourgois]

LGTM