Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): rename send_usage into send_telemetry #313

Merged
merged 2 commits into from
Feb 11, 2020
Merged

feat(core): rename send_usage into send_telemetry #313

merged 2 commits into from
Feb 11, 2020

Conversation

QuentinBrosse
Copy link
Contributor

No description provided.

kindermoumoute
kindermoumoute requested changes Feb 10, 2020
View reviewed changes
scw/config_test.go Outdated Show resolved Hide resolved
scw/config_test.go Outdated Show resolved Hide resolved
loicbourgois
loicbourgois reviewed Feb 10, 2020
View reviewed changes
scw/config.go Outdated Show resolved Hide resolved
kindermoumoute
kindermoumoute approved these changes Feb 11, 2020
View reviewed changes
Copy link
Contributor

@kindermoumoute kindermoumoute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

loicbourgois
loicbourgois approved these changes Feb 11, 2020
View reviewed changes
Copy link
Contributor

@loicbourgois loicbourgois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuentinBrosse QuentinBrosse merged commit 047c88b into scaleway:master Feb 11, 2020
@QuentinBrosse QuentinBrosse deleted the APIGW-1819 branch February 11, 2020 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kindermoumoute kindermoumoute kindermoumoute approved these changes

@loicbourgois loicbourgois loicbourgois approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@QuentinBrosse @kindermoumoute @loicbourgois