Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(k8s): add default timeout to wait methods #323

Merged
merged 1 commit into from
Feb 18, 2020
Merged

fix(k8s): add default timeout to wait methods #323

merged 1 commit into from
Feb 18, 2020

Conversation

Sh4d1
Copy link
Contributor

@Sh4d1 Sh4d1 commented Feb 14, 2020

Signed-off-by: Patrik Cyvoct pcyvoct@scaleway.com

@Sh4d1
fix(k8s): add default timeout to WaitForCluster
f86b6c6 
Signed-off-by: Patrik Cyvoct <pcyvoct@scaleway.com>
@Sh4d1 Sh4d1 force-pushed the k8s_wait_default_timeout branch from 95c54d7 to f86b6c6 Compare February 18, 2020 12:14
loicbourgois
loicbourgois approved these changes Feb 18, 2020
View reviewed changes
Copy link
Contributor

@loicbourgois loicbourgois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loicbourgois loicbourgois merged commit c0637fa into scaleway:master Feb 18, 2020
@remyleone remyleone added the k8s Kubernetes Kapsule issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@golangcibot golangcibot golangcibot left review comments

@loicbourgois loicbourgois loicbourgois approved these changes

Assignees
No one assigned
Labels
k8s Kubernetes Kapsule issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sh4d1 @loicbourgois @golangcibot @remyleone