Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add github action for PR testing #332

Merged
merged 1 commit into from
Feb 19, 2020

Conversation

Sh4d1
Copy link
Contributor

@Sh4d1 Sh4d1 commented Feb 19, 2020

This PR adds GitHub actions in order to test the reliability of the solution for a few months

Signed-off-by: Patrik Cyvoct pcyvoct@scaleway.com

Signed-off-by: Patrik Cyvoct <pcyvoct@scaleway.com>
Copy link
Contributor

@loicbourgois loicbourgois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this necessary ?
Isn't CircleCI enough ?

Please provide some context in the description

@Sh4d1
Copy link
Contributor Author

Sh4d1 commented Feb 19, 2020

After an irl discussion between @jtherin and @jerome-quere , it may be interesting to test GitHub actions in parallel with circle ci. (Description edted)

Copy link
Contributor

@loicbourgois loicbourgois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loicbourgois loicbourgois merged commit 652d928 into scaleway:master Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants