Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config): LoadConfigFromPath better handle cross platform error #395

Merged
merged 2 commits into from
Apr 28, 2020
Merged

fix(config): LoadConfigFromPath better handle cross platform error #395

merged 2 commits into from
Apr 28, 2020

Conversation

jerome-quere
Copy link
Contributor

No description provided.

@jerome-quere jerome-quere mentioned this pull request Apr 27, 2020
Merged
Sh4d1
Sh4d1 suggested changes Apr 27, 2020
View reviewed changes
scw/config.go Show resolved Hide resolved
@jerome-quere jerome-quere requested a review from Sh4d1 April 28, 2020 11:01
Sh4d1
Sh4d1 approved these changes Apr 28, 2020
View reviewed changes
Copy link
Contributor

@Sh4d1 Sh4d1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerome-quere jerome-quere merged commit 7ec36cc into master Apr 28, 2020
@jerome-quere jerome-quere deleted the configexist-cross branch April 28, 2020 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sh4d1 Sh4d1 Sh4d1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jerome-quere @Sh4d1