Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(errors): handle all instance not found return messages #432

Merged
merged 4 commits into from
Jun 5, 2020
Merged

fix(errors): handle all instance not found return messages #432

merged 4 commits into from
Jun 5, 2020

Conversation

Sh4d1
Copy link
Contributor

@Sh4d1 Sh4d1 commented Jun 2, 2020

Signed-off-by: Patrik Cyvoct pcyvoct@scaleway.com

Sh4d1 added 2 commits June 2, 2020 19:16
@Sh4d1
fix(errors): handle all instance not found return messages
1f581c7 
Signed-off-by: Patrik Cyvoct <pcyvoct@scaleway.com>
@Sh4d1
fix
4acf331 
Signed-off-by: Patrik Cyvoct <pcyvoct@scaleway.com>
@remyleone remyleone linked an issue Jun 3, 2020 that may be closed by this pull request
Inconsistant error on Delete #429
Closed
@Sh4d1
fix
199f74d 
Signed-off-by: Patrik Cyvoct <pcyvoct@scaleway.com>
@jerome-quere
Copy link
Contributor

jerome-quere commented Jun 4, 2020 •
edited
Loading

@kindermoumoute un avis ?

jerome-quere
jerome-quere approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@jerome-quere jerome-quere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kindermoumoute
kindermoumoute approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@kindermoumoute kindermoumoute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sh4d1 Sh4d1 merged commit 18adb17 into scaleway:master Jun 5, 2020
@remyleone remyleone added the instance Instance issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerome-quere jerome-quere jerome-quere approved these changes

@kindermoumoute kindermoumoute kindermoumoute approved these changes

Assignees
No one assigned
Labels
instance Instance issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistant error on Delete
4 participants
@Sh4d1 @jerome-quere @kindermoumoute @remyleone