Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fetch): check response is of proper type without using instanceof #536

Merged
merged 3 commits into from
Mar 27, 2023

Conversation

Vinzius
Copy link
Contributor

@Vinzius Vinzius commented Mar 21, 2023

No description provided.

@Vinzius Vinzius linked an issue Mar 21, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Merging #536 (afd124e) into main (a2fd61e) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #536   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           44        45    +1     
  Lines          636       638    +2     
  Branches       129       130    +1     
=========================================
+ Hits           636       638    +2     
Impacted Files Coverage Δ
packages/clients/src/helpers/is-response.ts 100.00% <100.00%> (ø)
packages/clients/src/scw/fetch/response-parser.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Vinzius Vinzius changed the title Draft: fix(fetch): check response is of proper type without using instanceof fix(fetch): check response is of proper type without using instanceof Mar 27, 2023
@Vinzius Vinzius added this pull request to the merge queue Mar 27, 2023
Merged via the queue into main with commit e1184d1 Mar 27, 2023
@Vinzius Vinzius deleted the fix/response-type branch March 27, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scaleway sdk with remix run leads to TypeError: Invalid response object
4 participants