Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add multiple handlers server #32

Merged
merged 3 commits into from
Apr 27, 2023
Merged

Conversation

cyclimse
Copy link
Collaborator

Summary

What's changed?

Added the LocalFunctionServer class to make it possible to serve multiple handlers.

Why do we need this?

Make it possible to test multiple handlers and integration with other tools

How have you tested it?

Added a simple unit test.

Checklist

  • I have reviewed this myself
  • There is a unit test covering every change in this PR
  • I have updated the relevant documentation

Details

@cyclimse cyclimse added the enhancement New feature or request label Apr 26, 2023
@cyclimse cyclimse self-assigned this Apr 26, 2023
@cyclimse cyclimse requested a review from Bemilie April 26, 2023 10:34
@cyclimse cyclimse requested a review from Shillaker April 26, 2023 11:33
@cyclimse cyclimse marked this pull request as ready for review April 26, 2023 11:33
Shillaker
Shillaker previously approved these changes Apr 26, 2023
Copy link
Contributor

@Shillaker Shillaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, really nice to abstract the local serving behind the server class.

Co-authored-by: Simon Shillaker <554768+Shillaker@users.noreply.github.com>
@cyclimse cyclimse requested a review from Shillaker April 26, 2023 13:12
@cyclimse cyclimse merged commit 7d7b951 into main Apr 27, 2023
@cyclimse cyclimse deleted the feat/multiple_handlers_server branch April 27, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants