fix(rdb): support sbs_15k on update (#2599)

* fix(rdb): support sbs_15k on update * update cassette
scaleway · Jun 4, 2024 · 66a6940 · 66a6940
1 parent 3451ac3
commit 66a6940
Show file tree

Hide file tree

Showing 4 changed files with 1,726 additions and 310 deletions.
diff --git a/docs/resources/rdb_instance.md b/docs/resources/rdb_instance.md
@@ -16,14 +16,30 @@ For more information, see [the documentation](https://www.scaleway.com/en/develo
 resource "scaleway_rdb_instance" "main" {
   name           = "test-rdb"
   node_type      = "DB-DEV-S"
-  engine         = "PostgreSQL-11"
+  engine         = "PostgreSQL-15"
   is_ha_cluster  = true
   disable_backup = true
   user_name      = "my_initial_user"
   password       = "thiZ_is_v&ry_s3cret"
 }
 ```
 
+### Example Block Storage Low Latency
+
+```terraform
+resource "scaleway_rdb_instance" "main" {
+  name              = "test-rdb-sbs"
+  node_type         = "db-play2-pico"
+  engine            = "PostgreSQL-15"
+  is_ha_cluster     = true
+  disable_backup    = true
+  user_name         = "my_initial_user"
+  password          = "thiZ_is_v&ry_s3cret"
+  volume_type       = "sbs_15k"
+  volume_size_in_gb = 10
+}
+```
+
 ### Example with Settings
 
 ```terraform
@@ -49,7 +65,7 @@ resource "scaleway_rdb_instance" "main" {
 resource "scaleway_rdb_instance" "main" {
   name          = "test-rdb"
   node_type     = "DB-DEV-S"
-  engine        = "PostgreSQL-11"
+  engine        = "PostgreSQL-15"
   is_ha_cluster = true
   user_name     = "my_initial_user"
   password      = "thiZ_is_v&ry_s3cret"
@@ -75,7 +91,7 @@ resource "scaleway_vpc_private_network" "pn" {
 
 resource "scaleway_rdb_instance" "main" {
   node_type         = "db-dev-s"
-  engine            = "PostgreSQL-11"
+  engine            = "PostgreSQL-15"
   private_network {
     pn_id  = scaleway_vpc_private_network.pn.id
     ip_net = "172.16.20.4/22"   # IP address within a given IP network
@@ -91,7 +107,7 @@ resource "scaleway_vpc_private_network" "pn" {}
 
 resource "scaleway_rdb_instance" "main" {
   node_type      = "DB-DEV-S"
-  engine         = "PostgreSQL-11"
+  engine         = "PostgreSQL-15"
   private_network {
     pn_id = scaleway_vpc_private_network.pn.id
     enable_ipam = true
@@ -105,7 +121,7 @@ resource "scaleway_rdb_instance" "main" {
 ```terraform
 resource "scaleway_rdb_instance" "main" {
   node_type         = "db-dev-s"
-  engine            = "PostgreSQL-11"
+  engine            = "PostgreSQL-15"
 }  
 ```
 

diff --git a/internal/services/rdb/instance.go b/internal/services/rdb/instance.go
@@ -546,7 +546,7 @@ func ResourceRdbInstanceUpdate(ctx context.Context, d *schema.ResourceData, m in
 	// Volume type and size
 	if d.HasChanges("volume_type", "volume_size_in_gb") {
 		switch volType {
-		case rdb.VolumeTypeBssd, rdb.VolumeTypeSbs5k:
+		case rdb.VolumeTypeBssd, rdb.VolumeTypeSbs5k, rdb.VolumeTypeSbs15k:
 			if d.HasChange("volume_type") {
 				upgradeInstanceRequests = append(upgradeInstanceRequests,
 					rdb.UpgradeInstanceRequest{

diff --git a/internal/services/rdb/instance_test.go b/internal/services/rdb/instance_test.go
@@ -968,6 +968,28 @@ func TestAccInstance_SBSVolume(t *testing.T) {
 					resource.TestCheckResourceAttr("scaleway_rdb_instance.main", "volume_size_in_gb", "20"),
 				),
 			},
+			{
+				Config: fmt.Sprintf(`
+					resource scaleway_rdb_instance main {
+						name = "test-rdb-instance-volume"
+						node_type = "db-play2-pico"
+						engine = %q
+						is_ha_cluster = false
+						disable_backup = true
+						user_name = "my_initial_user"
+						password = "thiZ_is_v&ry_s3cret"
+						region= "nl-ams"
+						tags = [ "terraform-test", "scaleway_rdb_instance", "volume" ]
+						volume_type = "sbs_15k"
+						volume_size_in_gb = 20
+					}
+				`, latestEngineVersion),
+				Check: resource.ComposeTestCheckFunc(
+					isInstancePresent(tt, "scaleway_rdb_instance.main"),
+					resource.TestCheckResourceAttr("scaleway_rdb_instance.main", "volume_type", "sbs_15k"),
+					resource.TestCheckResourceAttr("scaleway_rdb_instance.main", "volume_size_in_gb", "20"),
+				),
+			},
 		},
 	})
 }

diff --git a/internal/services/rdb/testdata/instance-sbs-volume.cassette.yaml b/internal/services/rdb/testdata/instance-sbs-volume.cassette.yaml