Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mnq): add sns #2274

Merged
merged 27 commits into from
Dec 19, 2023
Merged

feat(mnq): add sns #2274

merged 27 commits into from
Dec 19, 2023

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Dec 5, 2023

No description provided.

@Codelax Codelax added the mnq Messaging and queuing issues, bugs and feature requests label Dec 5, 2023
@Codelax Codelax self-assigned this Dec 5, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2023

Codecov Report

Attention: 295 lines in your changes are missing coverage. Please review.

Comparison is base (497fec6) 73.72% compared to head (90cdaa9) 73.56%.
Report is 25 commits behind head on master.

Files Patch % Lines
scaleway/resource_mnq_sns_topic.go 58.94% 64 Missing and 14 partials ⚠️
scaleway/helpers_mnq.go 59.73% 45 Missing and 15 partials ⚠️
scaleway/resource_mnq_sns_topic_subscription.go 65.69% 40 Missing and 19 partials ⚠️
scaleway/helpers_mnq_sns.go 62.13% 26 Missing and 13 partials ⚠️
scaleway/resource_mnq_sns_credentials.go 80.76% 21 Missing and 9 partials ⚠️
scaleway/resource_mnq_sns.go 66.66% 17 Missing and 8 partials ⚠️
scaleway/helpers_mnq_state.go 95.65% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2274      +/-   ##
==========================================
- Coverage   73.72%   73.56%   -0.17%     
==========================================
  Files         218      224       +6     
  Lines       33778    34732     +954     
==========================================
+ Hits        24904    25551     +647     
- Misses       6745     6975     +230     
- Partials     2129     2206      +77     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Codelax Codelax marked this pull request as ready for review December 19, 2023 12:46
@Codelax Codelax linked an issue Dec 19, 2023 that may be closed by this pull request
5 tasks
@remyleone remyleone added this pull request to the merge queue Dec 19, 2023
Merged via the queue into scaleway:master with commit d7ac009 Dec 19, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mnq Messaging and queuing issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MNQ support SQS/SNS
3 participants