Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(instance): fix plugin segfault when bootscript is null #2664

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

utix
Copy link
Contributor

@utix utix commented Jul 27, 2024

Bootscript is deprecated cf https://www.scaleway.com/en/developers/api/instance/#path-instances-list-all-instances

image

seems relative to https://www.scaleway.com/en/docs/compute/instances/troubleshooting/bootscript-eol/

It appears that Bootscript is no longer available on API response

@utix utix requested a review from Codelax as a code owner July 27, 2024 20:26
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.03%. Comparing base (fe86049) to head (4732203).
Report is 123 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2664      +/-   ##
==========================================
- Coverage   71.43%   71.03%   -0.40%     
==========================================
  Files         277      334      +57     
  Lines       35875    33475    -2400     
==========================================
- Hits        25628    23780    -1848     
+ Misses       8028     7388     -640     
- Partials     2219     2307      +88     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remyleone remyleone changed the title fix(servers): fix plugin segfault when bootscript is null fix(instance): fix plugin segfault when bootscript is null Jul 29, 2024
@remyleone remyleone added this pull request to the merge queue Jul 29, 2024
Merged via the queue into scaleway:master with commit b8de73d Jul 29, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants