Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apple-silicon): increase timeout for server creation #2704

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

reda-maizate
Copy link
Contributor

@reda-maizate reda-maizate commented Aug 16, 2024

Problem occured:
While trying to create a M2-L server using Terraform and the Scaleway provider, I got a timeout after 2 minutes which seems short for a server creation. With a timeout this short, it makes the developer experience quite bad because the Apple Silicon's server needs to be used at least an entire day (24 hours) before I can destroy them.

Solutions:
I found 2 solutions, 1 short term and 1 long term. Here there are:

  1. Short term: We can fix this issue easily by adding this piece of code in the scaleway_apple_silicon_server resource:
resource scaleway_apple_silicon_server "server" {
...
timeouts {
    create = "20m" 
  }
...
}
  1. Long term: We can also just increase the duration of the timeout to 20 minutes, the default for a creation in Terraform (source here: https://developer.hashicorp.com/terraform/plugin/sdkv2/resources/retries-and-customizable-timeouts#default-timeouts-and-deadline-exceeded-errors).

I recommend the long term solution, that's why I created this PR.

Have a nice day! 👍

@reda-maizate reda-maizate requested a review from Laure-di as a code owner August 16, 2024 13:42
@github-actions github-actions bot added the apple-silicon Apple Silicon issues, bugs and feature requests label Aug 16, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.12%. Comparing base (fe86049) to head (3b959c7).
Report is 147 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2704      +/-   ##
==========================================
- Coverage   71.43%   71.12%   -0.32%     
==========================================
  Files         277      335      +58     
  Lines       35875    33740    -2135     
==========================================
- Hits        25628    23998    -1630     
+ Misses       8028     7411     -617     
- Partials     2219     2331     +112     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Codelax Codelax added this pull request to the merge queue Aug 20, 2024
Merged via the queue into scaleway:master with commit 6ca5bb8 Aug 20, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apple-silicon Apple Silicon issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants