Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(instance_server): mark private_ip as deprecated #2852

Merged

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Dec 13, 2024

Close #2772

@Codelax Codelax added documentation instance Instance issues, bugs and feature requests labels Dec 13, 2024
@Codelax Codelax requested a review from remyleone as a code owner December 13, 2024 14:22
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.75%. Comparing base (fe86049) to head (ebc7645).
Report is 250 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2852      +/-   ##
==========================================
- Coverage   71.43%   67.75%   -3.69%     
==========================================
  Files         277      339      +62     
  Lines       35875    40209    +4334     
==========================================
+ Hits        25628    27244    +1616     
- Misses       8028    10646    +2618     
- Partials     2219     2319     +100     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remyleone remyleone added this pull request to the merge queue Dec 17, 2024
Merged via the queue into scaleway:master with commit ce02850 Dec 17, 2024
44 checks passed
jremy42 pushed a commit that referenced this pull request Jan 30, 2025
* doc(instance_server): mark private_ip as deprecated

* fix link

* add deprecation notice in schema
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation instance Instance issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

private_ip is null for scaleway_instance_server resource
3 participants