feat: new library for advanced components #2982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d4de7a5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2982 +/- ##
==========================================
+ Coverage 93.65% 93.75% +0.10%
==========================================
Files 156 159 +3
Lines 3295 3349 +54
Branches 426 433 +7
==========================================
+ Hits 3086 3140 +54
Misses 139 139
Partials 70 70
Continue to review full report in Codecov by Sentry.
|
matthprost
force-pushed
the
feat/new-library
branch
5 times, most recently
from
7f53dbb to
7df0b84
Compare
matthprost
requested review from
PetmePant,
a team,
ModuloM,
QuiiBz and
fabienhebert
and removed request for
a team
PetmePant
previously requested changes
Oct 4, 2023
There was a problem hiding this comment.
Storybook related:
- Add a fixed width in the preview component so is not huge
- Add some custom stories so we showcase the possibilities to our users (slot/children)
- There is an issue that you can hide image/icon even if you dont have any content in the prop
Component related:
- Fix icon sizes so it's the same for both directions
- Add the option of loading state (check specifications)
- Broder on hover state should be primary
matthprost
force-pushed
the
feat/new-library
branch
5 times, most recently
from
f256079 to
a5fdfde
Compare
ModuloM
approved these changes
Oct 9, 2023
vincentaudebert
approved these changes
Oct 10, 2023
JulienSaguez
approved these changes
Oct 10, 2023
matthprost
force-pushed
the
feat/new-library
branch
from
c63b899 to
4abaeed
Compare
matthprost
force-pushed
the
feat/new-library
branch
from
4abaeed to
c494974
Compare
PetmePant
previously requested changes
Oct 10, 2023
PetmePant
approved these changes
Oct 11, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Type
✨ New Library for complex component
Ultraviolet UI is our simple library for basic components with very low composition. We needed one more library to increase the complexity of our component that couldn't fit there.
One first component is added into it: ContentCard.
A simple component to display information with images, title, description, icon or anything else.