Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: table and list to hide scroll bar is no overflow #4587

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Conversation

matthprost
Copy link
Collaborator

@matthprost matthprost commented Dec 16, 2024

Summary

Type

  • Bug

Summarise concisely:

What is expected?

Hide scroll bar on overflow x if there is no overflow.

Relevant logs and/or screenshots

Page Before After
url Screenshot 2024-12-16 at 08 55 32 Screenshot 2024-12-16 at 08 55 39
url Screenshot 2024-12-16 at 11 19 17 Screenshot 2024-12-16 at 11 19 25

@matthprost matthprost added the bug Something isn't working label Dec 16, 2024
@matthprost matthprost requested a review from a team December 16, 2024 08:30
@matthprost matthprost self-assigned this Dec 16, 2024
@matthprost matthprost removed the request for review from a team December 16, 2024 08:30
@matthprost matthprost requested a review from lisalupi as a code owner December 16, 2024 08:30
Copy link

changeset-bot bot commented Dec 16, 2024

🦋 Changeset detected

Latest commit: 3e5af68

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Patch
@ultraviolet/form Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.60%. Comparing base (bb0353a) to head (3e5af68).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/ui/src/components/List/HeaderRow.tsx 66.66% 1 Missing ⚠️
packages/ui/src/components/List/Row.tsx 83.33% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4587      +/-   ##
==========================================
+ Coverage   87.59%   87.60%   +0.01%     
==========================================
  Files         335      335              
  Lines       12805    12808       +3     
  Branches     3531     3488      -43     
==========================================
+ Hits        11216    11221       +5     
+ Misses       1589     1587       -2     
Files with missing lines Coverage Δ
packages/ui/src/components/List/constants.tsx 100.00% <100.00%> (+100.00%) ⬆️
packages/ui/src/components/List/index.tsx 100.00% <ø> (ø)
packages/ui/src/components/Table/index.tsx 100.00% <ø> (ø)
packages/ui/src/components/List/HeaderRow.tsx 93.33% <66.66%> (ø)
packages/ui/src/components/List/Row.tsx 92.85% <83.33%> (+0.19%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d056b3...3e5af68. Read the comment docs.

@matthprost matthprost merged commit 907b477 into main Dec 16, 2024
12 of 13 checks passed
@matthprost matthprost deleted the fix/list branch December 16, 2024 14:36
@scaleway-bot scaleway-bot mentioned this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants