Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Text): add strike through on text #4595

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matthprost
Copy link
Collaborator

Summary

Type

  • Enhancement

Summarise concisely:

What is expected?

  • Add prop strikethrough on Text component
  • Add another example of estimate cost on storybook

Relevant logs and/or screenshots

Screenshot 2024-12-17 at 15 27 46

@matthprost matthprost added the enhancement New feature or request label Dec 17, 2024
@matthprost matthprost requested a review from a team December 17, 2024 14:27
@matthprost matthprost self-assigned this Dec 17, 2024
@matthprost matthprost requested review from BABAK0T0 and removed request for a team December 17, 2024 14:28
@matthprost matthprost requested a review from lisalupi as a code owner December 17, 2024 14:28
@matthprost matthprost requested a review from Lawndlwd December 17, 2024 14:28
Copy link

changeset-bot bot commented Dec 17, 2024

🦋 Changeset detected

Latest commit: b92cf10

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Patch
@ultraviolet/form Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.61%. Comparing base (bb0353a) to head (b92cf10).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4595      +/-   ##
==========================================
+ Coverage   87.59%   87.61%   +0.02%     
==========================================
  Files         335      335              
  Lines       12805    12810       +5     
  Branches     3531     3535       +4     
==========================================
+ Hits        11216    11223       +7     
+ Misses       1589     1587       -2     
Files with missing lines Coverage Δ
packages/ui/src/components/Text/index.tsx 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a04150...b92cf10. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants