fix(Modal): remove unecessary stop propagation #4614
+73
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthprost
requested review from
johnrazeur,
fabienhebert and
DorianMaliszewski
🦋 Changeset detectedLatest commit: 466039c The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
matthprost
force-pushed
the
fix/remove-stop-propagation-modal
branch
from
121262b to
badeddf
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4614 +/- ##
=======================================
Coverage 87.45% 87.45%
=======================================
Files 335 335
Lines 12812 12813 +1
Branches 3534 3538 +4
=======================================
+ Hits 11205 11206 +1
Misses 1607 1607
Continue to review full report in Codecov by Sentry.
|
DorianMaliszewski
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Type
Summarise concisely:
What is expected?
Remove unnecessary stop propagation on modal blocking any popup within the modal to close when clicking inside the modal itself.
Relevant logs and/or screenshots
Before:
Screen.Recording.2024-12-20.at.10.01.39.mov
After:
Screen.Recording.2024-12-20.at.10.02.40.mov