-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/arsn 386/fix generate v4 headers for put with body requests #2209
Bugfix/arsn 386/fix generate v4 headers for put with body requests #2209
Conversation
Hello fredmnl,My role is to assist you with the merge of this Status report is not available. |
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command:
Alternatively, the |
d9c339e
to
29f39ab
Compare
/create_integration_branches |
ConflictA conflict has been raised during the creation of I have not created the integration branch. Here are the steps to resolve this conflict: $ git fetch
$ git checkout -B w/7.70/bugfix/ARSN-386/fix-generate-v4-headers-for-put-with-body-requests origin/development/7.70
$ git merge origin/bugfix/ARSN-386/fix-generate-v4-headers-for-put-with-body-requests
$ # <intense conflict resolution>
$ git commit
$ git push -u origin w/7.70/bugfix/ARSN-386/fix-generate-v4-headers-for-put-with-body-requests The following options are set: create_integration_branches |
ConflictA conflict has been raised during the creation of I have not created the integration branch. Here are the steps to resolve this conflict: $ git fetch
$ git checkout -B w/8.1/bugfix/ARSN-386/fix-generate-v4-headers-for-put-with-body-requests origin/development/8.1
$ git merge origin/w/7.70/bugfix/ARSN-386/fix-generate-v4-headers-for-put-with-body-requests
$ # <intense conflict resolution>
$ git commit
$ git push -u origin w/8.1/bugfix/ARSN-386/fix-generate-v4-headers-for-put-with-body-requests The following options are set: create_integration_branches |
/approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve, create_integration_branches |
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue ARSN-386. Goodbye fredmnl. |
When attempting to send lifecycle configuration requests to AWS with this in-house client, I found that it did not include the necessary
content-md5
header. Unfortunately this header is also used when callingbackbeat
's internal routes but the hash is expressed in hex form, not in base64.Thus, I chose to go down the simplest path which is to add the header anyway but choose the encoding based on the route of the request. I am also adding the header all of the time, this does not have a negative impact on our tests in cloudserver (except for the one testing the behavior when the header is not present).