Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement/zenko 4713 tests on put obj no version #2098

Merged

Conversation

benzekrimaha
Copy link
Contributor

@benzekrimaha benzekrimaha commented Jul 2, 2024

This PR aims to add a test case on the dmfFeature , for the put of an existing object in the cold lolcation in the hot one , in the test we make sure that dmf deletes the already existing object in the cold storage , before the hot location object is transitioned thus avoiding the creation of orphans.

Issue : ZENKO-4713

@bert-e
Copy link
Contributor

bert-e commented Jul 2, 2024

Hello benzekrimaha,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Jul 2, 2024

Incorrect fix version

The Fix Version/s in issue ZENKO-4713 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 2.7.54

  • 2.8.34

  • 2.9.8

Please check the Fix Version/s of ZENKO-4713, or the target
branch of this pull request.

@@ -13,10 +13,10 @@ busybox:
tag: 1.33.0
envsubst: BUSYBOX_TAG
cloudserver:
sourceRegistry: ghcr.io/scality
sourceRegistry: ghcr.io/scality/playground
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be changed once CLDSRV released

@benzekrimaha benzekrimaha force-pushed the improvement/ZENKO-4713-tests-on-putObjNoVersion branch from facb814 to 0846e1f Compare July 3, 2024 07:03
@benzekrimaha benzekrimaha force-pushed the improvement/ZENKO-4713-tests-on-putObjNoVersion branch from 5f94aa9 to a480900 Compare July 10, 2024 13:07
@bert-e
Copy link
Contributor

bert-e commented Jul 11, 2024

Incorrect fix version

The Fix Version/s in issue ZENKO-4713 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 2.7.55

  • 2.8.35

  • 2.9.9

Please check the Fix Version/s of ZENKO-4713, or the target
branch of this pull request.

@bert-e
Copy link
Contributor

bert-e commented Jul 12, 2024

Incorrect fix version

The Fix Version/s in issue ZENKO-4713 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 2.10.0

  • 2.7.55

  • 2.8.35

  • 2.9.9

Please check the Fix Version/s of ZENKO-4713, or the target
branch of this pull request.

@benzekrimaha benzekrimaha force-pushed the improvement/ZENKO-4713-tests-on-putObjNoVersion branch 3 times, most recently from 3b38374 to 33988ab Compare July 15, 2024 13:41
@benzekrimaha benzekrimaha force-pushed the improvement/ZENKO-4713-tests-on-putObjNoVersion branch from be86c13 to d368089 Compare July 18, 2024 16:05
@scality scality deleted a comment from bert-e Jul 18, 2024
@benzekrimaha
Copy link
Contributor Author

/create_integration_branches

@scality scality deleted a comment from bert-e Jul 18, 2024
@scality scality deleted a comment from bert-e Jul 18, 2024
@bert-e
Copy link
Contributor

bert-e commented Jul 18, 2024

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/2.5
  • development/2.6

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: create_integration_branches

@bert-e
Copy link
Contributor

bert-e commented Jul 18, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following options are set: create_integration_branches

@benzekrimaha
Copy link
Contributor Author

@bert-e create_pull_requests

@bert-e
Copy link
Contributor

bert-e commented Jul 18, 2024

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/2.5
  • development/2.6

Follow integration pull requests if you would like to be notified of
build statuses by email.

The following options are set: create_pull_requests, create_integration_branches

@bert-e
Copy link
Contributor

bert-e commented Jul 18, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following options are set: create_pull_requests, create_integration_branches

@benzekrimaha
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Jul 18, 2024

Build failed

The build for commit did not succeed in branch w/2.8/improvement/ZENKO-4713-tests-on-putObjNoVersion.

The following options are set: approve, create_pull_requests, create_integration_branches

@bert-e
Copy link
Contributor

bert-e commented Jul 19, 2024

Build failed

The build for commit did not succeed in branch w/2.9/improvement/ZENKO-4713-tests-on-putObjNoVersion.

The following options are set: approve, create_pull_requests, create_integration_branches

@bert-e
Copy link
Contributor

bert-e commented Jul 19, 2024

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/2.7

  • ✔️ development/2.8

  • ✔️ development/2.9

  • ✔️ development/2.10

The following branches will NOT be impacted:

  • development/2.5
  • development/2.6

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve, create_pull_requests, create_integration_branches

@bert-e
Copy link
Contributor

bert-e commented Jul 20, 2024

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/2.7

  • ✔️ development/2.8

  • ✔️ development/2.9

  • ✔️ development/2.10

The following branches have NOT changed:

  • development/2.5
  • development/2.6

Please check the status of the associated issue ZENKO-4713.

Goodbye benzekrimaha.

@bert-e bert-e merged commit 081b907 into development/2.7 Jul 20, 2024
15 checks passed
@bert-e bert-e deleted the improvement/ZENKO-4713-tests-on-putObjNoVersion branch July 20, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants