DSET-3468: update dataset-go to latest, send more details in user-agent #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaz-s1
approved these changes
Jun 22, 2023
tomaz-s1
reviewed
Jun 23, 2023
|
|
||
| userAgent := fmt.Sprintf( | ||
| "%s;%s;%s", | ||
| "OtelCollector", |
There was a problem hiding this comment.
Should we also include datasetexporter somewhere in this fragment? Or you think it's not needed since it will always be dataset exporter when the fragment also contains OtelCollector.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: updated dataset-go library, send more details in user-agent
For more details see https://github.com/scalyr/dataset-go/releases/tag/v0.0.9
Link to tracking Issue: 20660 / DSET-3468
Testing: TBD
Documentation: see https://github.com/scalyr/dataset-go/blob/fbaead7856a9c5669262564dfa4a13aa14a0775d/examples/readme/main.go#L81