-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Item and Menu managers and updated their models #26
base: master
Are you sure you want to change the base?
Added Item and Menu managers and updated their models #26
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGFM, but fix please docblocks
src/Api/ItemManagerInterface.php
Outdated
/** | ||
* @category ScandiPWA | ||
* @package ScandiPWA\MenuOrganizer\Api | ||
* @author Vladislavs Zimnikovs <info@scandiweb.com> | ||
* @copyright Copyright (c) 2022 Scandiweb, Ltd (http://scandiweb.com) | ||
* @license http://opensource.org/licenses/afl-3.0.php Academic Free License (AFL 3.0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doc block not in the correct position. Should be at begging.
src/Api/MenuManagerInterface.php
Outdated
/** | ||
* @category ScandiPWA | ||
* @package ScandiPWA\MenuOrganizer\Api | ||
* @author Vladislavs Zimnikovs <info@scandiweb.com> | ||
* @copyright Copyright (c) 2022 Scandiweb, Ltd (http://scandiweb.com) | ||
* @license http://opensource.org/licenses/afl-3.0.php Academic Free License (AFL 3.0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same and so on
No description provided.