Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added setTheme function in willLoad #578

Merged
merged 1 commit into from
Sep 4, 2020
Merged

Added setTheme function in willLoad #578

merged 1 commit into from
Sep 4, 2020

Conversation

helloimela
Copy link
Contributor

  • It will make sure to load the theme before element is rendered in the view (didLoad)
  • Somehow in Angular 10, the theme is not fetched from store in willLoad stage, cause it to cause error when component is rendered it cannot get correct theme styling

Solving issue
Fixes: #577

How to test

  • Test in Angular 9 or 10 setup

Added setTheme function in willLoad
fe6045f 
- It will make sure to load the theme before element is rendered in the view (didLoad)
@helloimela helloimela self-assigned this Aug 25, 2020
@helloimela helloimela added the bug Something isn't working label Aug 25, 2020
mmexvr
mmexvr approved these changes Sep 4, 2020
View reviewed changes
Copy link
Member

@mmexvr mmexvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mmexvr mmexvr merged commit 6e2f014 into master Sep 4, 2020
@mmexvr mmexvr deleted the bug/c-table-incorrect-theme-loading branch November 12, 2020 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gustavookamoto gustavookamoto gustavookamoto approved these changes

@mmexvr mmexvr mmexvr approved these changes

Assignees

@helloimela helloimela

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug - Problems to implement c-table with pre-release version
3 participants
@helloimela @mmexvr @gustavookamoto