Bug - Footer styling in FF, changing theme cause error with icons and html attribute #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and html attribute bug - Added fallback for themes without version in the attribute on the HTML element - Added fallback support for themes without icon packages - Solves issue with footer in VUE not appending correct styling in FireFox - This commit is related with the issue in SDDS regarding icons
mmexvr
changed the title
helloimela
reviewed
Sep 16, 2020
|
|
||
| // This is used by browsers with support for shadowdom | ||
| // If the browser has support for adoptedStyleSheet (Chromium) |
There was a problem hiding this comment.
The previous statement is actually correct. Because el.shadowRoot is only exist for browser that support shadow DOM. And adaptedStyleSheet is part of that.
There was a problem hiding this comment.
The condition check if the browser has support specifically for adoptedStyletSheet not shadowDOM.
ShadowDOM is supported by a lot browsers but not a lot of browsers support adoptedStyleSheet API.
helloimela
approved these changes
Sep 16, 2020
helloimela
deleted the
bug/fix_footer_and_fallback_for_icon_and_attribute
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe pull-request
Describe what the pull-request is about
Solving issue
Add which issue this pull-request solves by adding # plus the number of the issue (for example #123)
Fixes: #582 fixes: #583
How to test
Add description how to test if possible
Seconding fix
Screenshots
If applicable, add screenshots to help explain
Additional context
Add any other context about the pull-request here.