Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement/upgrade stencil 2 #594

Merged
merged 13 commits into from
Nov 9, 2020
Merged

Conversation

helloimela
Copy link
Contributor

Describe pull-request

  • Update core to stencil 2
  • Use stencil store instead of Redux

How to test

  1. Do npm link for corporate-ui and scania-theme (Improvement/stencil 2 upgrade scania-theme#155)
  2. Check in both NPM and CDN ways of loading script
  3. Check if all components work
  4. Check in mobile if navigation works properly

Screenshots
If applicable, add screenshots to help explain

Additional context
Add any other context about the pull-request here.

Ela Yudhanira added 5 commits October 27, 2020 15:52
@helloimela helloimela self-assigned this Nov 3, 2020
@helloimela helloimela added the Improvement Improvement of already existing feature label Nov 3, 2020
@mmexvr
Copy link
Member

mmexvr commented Nov 8, 2020

  • Do npm link for corporate-ui and scania-theme (Improvement/stencil 2 upgrade scania-theme#155) approved in scania-theme
    • Tried in chrome,ff,edge, safari and ie
  • Check in both NPM and CDN ways of loading script
    • Some smaller loading issue with IE/edge code example, only site uses code example
  • Check if all components work
    • C-header, c-navigation, c-footer, c-content, c-dealer-header and c-cookie works in the same way as before in Chrome, ff, safari and internet explorer.
  • Check in mobile if navigation works properly
    • Works in Chrome, FF and Safari

Some issue with "EBUSY copy" config that might be related with the new version of stencil. this also effects the build process after, you need to delete dist folder to make it able to rebuild, otherwise nothing will happened

@helloimela helloimela merged commit e08bb07 into master Nov 9, 2020
@helloimela helloimela deleted the improvement/upgrade_stencil_2 branch November 9, 2020 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Improvement of already existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants