Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll/tracking issue on some devices #603

Closed
Zeynal7 opened this issue Aug 2, 2023 · 1 comment
Closed

Scroll/tracking issue on some devices #603

Zeynal7 opened this issue Aug 2, 2023 · 1 comment

Comments

@Zeynal7
Copy link

Zeynal7 commented Aug 2, 2023

Description

Scroll views inside the panel doesn't scroll for versions after 2.6.1 (2.6.1 is Okay)

It happens only for some devices, like iPhone 13 Pro Max, 12 Pro Max.
Most other devices that I tested seems fine.

  • Add as child view controllers

How many panels do you displays?

  • 1

Environment

Library version
2.6.2 and later

Installation method

  • Swift Package Manager

iOS version(s)
Latest versions

scenee added a commit that referenced this issue Aug 11, 2023
…inset

These issues arose in 'Show Navigation Controller' sample of Samples app.

1. The scrollView's contentOffset always becomes (0, 0) instead of (0, -44),
   which is normal if there is a UINavigationBar.

2. The scrollView's contentOffset sometimes becomes (0, 0) after moving
   a panel quickly like picking.

Case 1 is caused by 7511ce5 commit.
Case 2 is caused by a workaround added at 81fd85e commit.

I tested this library from iOS 11 to iOS 16, and then I confirmed this
workaround doesn't need anymore.

Related to #602, #603.
scenee added a commit that referenced this issue Aug 11, 2023
…inset

These issues arose in 'Show Navigation Controller' sample of Samples app.

1. The scrollView's contentOffset always becomes (0, 0) instead of (0, -44),
   which is normal if there is a UINavigationBar.

2. The scrollView's contentOffset sometimes becomes (0, 0) after moving
   a panel quickly like picking.

Case 1 is caused by 7511ce5 commit.
Case 2 is caused by a workaround added at 81fd85e commit.

I tested this library from iOS 11 to iOS 16, and then I confirmed this
workaround doesn't need anymore.

Related to #602, #603.
@scenee
Copy link
Owner

scenee commented Aug 11, 2023

I've fixed this issue on 2.6.6. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants