fix: collectors ignore watches with missing title (#22)

schaermu · Apr 16, 2024 · 0547a71 · 0547a71
1 parent 8ac0b80
commit 0547a71
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/pkg/collectors/watch_collector_test.go b/pkg/collectors/watch_collector_test.go
@@ -29,3 +29,16 @@ func TestWatchCollector(t *testing.T) {
 	//testutil.ExpectMetricCount(t, c, 2, expectedWatchMetrics...)
 	testutil.ExpectMetrics(t, c, "watch_metrics.prom", expectedWatchMetrics...)
 }
+
+func TestWatchCollector_IgnoresWatchesWithoutTitle(t *testing.T) {
+	_, watchDb := testutil.NewCollectorTestDb()
+	server := testutil.CreateTestApiServer(t, watchDb)
+	emptyUuid, emptyTitleItem := testutil.NewTestItem("", 100, "CHF", 20, 15, 10)
+	watchDb[emptyUuid] = emptyTitleItem
+	defer server.Close()
+
+	client := cdio.NewTestApiClient(server.URL())
+	c := NewWatchCollector(client)
+
+	testutil.ExpectMetrics(t, c, "watch_metrics.prom", expectedWatchMetrics...)
+}
diff --git a/pkg/data/api.go b/pkg/data/api.go
@@ -3,6 +3,7 @@
 package data
 
 import (
+	"fmt"
 	"net/url"
 )
 
@@ -38,5 +39,8 @@ func (w *WatchItem) GetMetrics() ([]string, error) {
 	if err != nil {
 		return nil, err
 	}
+	if w.Title == "" {
+		return nil, fmt.Errorf("title is empty")
+	}
 	return []string{w.Title, url.Host}, nil
 }