Fix encrypted storage bug #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update security-crypto fixing race condition
| @@ -28,27 +30,10 @@ internal interface SessionStorage { | |||
|
|
|||
| internal class EncryptedSharedPrefsStorage(context: Context) : SessionStorage { | |||
| private val gson = GsonBuilder().setDateFormat("MM dd, yyyy HH:mm:ss").create() | |||
| private val appContext: Context = context.applicationContext | |||
There was a problem hiding this comment.
not a fan of having to keep reference to app context here, but alternative was putting context as parameter in get, and that would cause a snowball of changes that wouldn't really make sense
|
Looking into reasons behind dropping this PR, will close changes and approve migration away from encrypted storage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is as alternative to removing EncryptedSharedPreferences.
EncryptedSharedPreferencesif they are corruptedsecurity-cryptofixing race condition (more info found here)