refactor: Avoid use of dockerpy. #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanCardin
force-pushed
the
dc/python-on-whales
branch
from
ad58479 to
cbb4744
Compare
DanCardin
force-pushed
the
dc/python-on-whales
branch
2 times, most recently
from
a1ce817 to
462ef7a
Compare
Codecov Report
@@ Coverage Diff @@
## main #157 +/- ##
==========================================
+ Coverage 82.71% 82.96% +0.25%
==========================================
Files 30 30
Lines 1313 1303 -10
Branches 185 186 +1
==========================================
- Hits 1086 1081 -5
+ Misses 187 182 -5
Partials 40 40
Continue to review full report at Codecov.
|
DanCardin
force-pushed
the
dc/python-on-whales
branch
3 times, most recently
from
682752a to
4420684
Compare
DanCardin
force-pushed
the
dc/python-on-whales
branch
from
4420684 to
93392d0
Compare
oakhan3
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker-py hasn't had a commit in a very long time and appears to be being dropped by docker docker/docker-py#2989.
The relevance to us is that docker-py generates a bunch of internal deprecation warnings that have had PRs available to be merged for a very long time, but haven't been being merged.
https://gabrieldemarmiesse.github.io/python-on-whales/ appears to be an alternative library which avoid reimplementing the docker client functionality, which makes it much simpler, and presumably less likely to cause maintenance issues (such as those warnings).
The risk seems pretty low, given how small a portion of the api surface we use; so it should be trivial to switch back if this becomes a problem, or docker-py gets resumed maintenance and we decide it's better than python-on-whales for any reason
fixes #156