Clean up the shallow copy #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilliamJamieson
commented
Jul 8, 2023
| result = self.__class__(init=None) | ||
| self.clone(result, self, deepcopy=True, memo=memo) | ||
| self.clone(result, self, deepcopy=deepcopy, memo=memo) |
There was a problem hiding this comment.
Note that I think this clone vs copy thing and the clone interface are both bizarre. In reality it should just all be unified into copy. Doing that is outside the scope of the reducing copies PR, so it can wait.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a suggestion for your spacetelescope#232 pull request.
I thought the way you had to make a shallow copy was very awkward, so I updated it so that it was less awkward. Feel free to reject, copy, or merge this suggestion.