Bug/resolve locale #156
Open
Bug/resolve locale #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 Can this PR be merged please ? |
|
Hi @qpautrat thanks for the patch, could you please rebase with the new master? |
|
@acasademont Done ! |
|
@qpautrat thanks but i'm afraid there must be something wrong here, in your PR there are also some of my commits and the diff is not clear. Can you please squash and make sure there's only 1 commit and the diff is clear? Thank! :D |
qpautrat
force-pushed
the
bug/resolve_locale
branch
from
4e9c49c
to
3f02d09
Compare
|
@acasademont Is this ok now ? I'm really sorry, i'm not used to do that, kind of beginner here. 😕 |
| @@ -192,6 +192,12 @@ private function matchI18n(array $params, $url) | |||
| $params['_route'] = substr($params['_route'], $pos + strlen(I18nLoader::ROUTING_PREFIX)); | |||
| } | |||
|
|
|||
| foreach($this->hostMap as $locale => $host) { | |||
| if ($host == $this->context->getHost()) { | |||
| $this->context->setParameter('_locale', $locale); | |||
There was a problem hiding this comment.
you should break the loop here once the locale is found
|
Thanks! Could you fix the small thing I mentioned and squash all the commits please? |
qpautrat
force-pushed
the
bug/resolve_locale
branch
from
2412b14
to
eec5fe8
Compare
|
@acasademont Done. |
|
what about this PR ? Could it be merged please ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve locale from current host
See #128