Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Symfony 4.4, update project dependencies, update test… #259

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DaanBiesterbos
Copy link

@DaanBiesterbos DaanBiesterbos commented Mar 8, 2021

Fix deprecation notices

  • Remove ContainerAwareCommand dependency
  • Update interface and dispatch calls to event manager (deprecated interface used)
  • Update references to deprecated @route annotation
  • Update references to the doctrine registry (current references break symfony 4 when using up to date doctrine bundle)
  • Use doctrine 2
  • Remove various deprecated interfaces
  • Update Twig extensions (modern classes)
  • Change kernel.root_dir to kernel.project_dir
  • Update tests to support PHPUnit 7 and up
  • Update Travis build
  • Minimal PHP version bumped to 7.3 (needed to avoid version conflicts when using up to date / maintained packages)

Remaining issues:

  • The detach method (entity manager) is deprecated and no replacement is available.
  • With Symfony 5 the commands must return a status code. Also, the constructor arguments to the Process class changed. Returning zero and update the creation of Process class still led to failing tests. For now this problem is not relevant. Symfony 5 would have been a nice extra. Note that I made the version constraint more avoid problems in Symfony 5 applications.
  • I really dislike the non dev dependency to symfony/debug. Please consider another solution.

@DaanBiesterbos DaanBiesterbos force-pushed the feature/support-symfony-4-fix-deprecation-errors-and-update-dependencies branch from 2ec4547 to af85b78 Compare March 11, 2021 11:31
@DaanBiesterbos DaanBiesterbos force-pushed the feature/support-symfony-4-fix-deprecation-errors-and-update-dependencies branch from eade815 to 7792fed Compare March 11, 2021 11:52
@y4roc
Copy link

y4roc commented Sep 8, 2021

@schmittjoh - Please merge it and release it as 3.1.1

@aeyoll
Copy link

aeyoll commented Nov 23, 2021

Hello @schmittjoh Can we get an update on this PR please? Thanks a lot

@DaanBiesterbos
Copy link
Author

@schmittjoh I am not actively developing this bundle but you can add me as a maitainer if you like. It seems like you are very busy working on other things ;-)

@fnagel
Copy link

fnagel commented Feb 21, 2022

I was running in following issue when testing the PR:

Error thrown while running command "jms-job-queue:run --max-runtime=300 --env=prod". Message: "Class 'Symfony\Component\Process\Process' not found"

It was needed to add composer require symfony/process. Please note the error did only pop-up when I was using PROD environment. Seems in DEV it was somehow installed due to a dev dependency.

After that I still had issues when requesting a job detail view:

[2022-02-21T09:10:00.189651+00:00] request.CRITICAL: Uncaught PHP Exception Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException: "The "JMS\JobQueueBundle\Controller\JobController::getParameter()" method is missing a parameter bag to work properly. Did you forget to register your controller as a service subscriber? This can be fixed either by using autoconfiguration or by manually wiring a "parameter_bag" in the service locator passed to the controller." at /var/www/html/vendor/symfony/framework-bundle/Controller/AbstractController.php line 68 {"exception":"[object] (Symfony\\Component\\DependencyInjection\\Exception\\ServiceNotFoundException(code: 0): The \"JMS\\JobQueueBundle\\Controller\\JobController::getParameter()\" method is missing a parameter bag to work properly. Did you forget to register your controller as a service subscriber? This can be fixed either by using autoconfiguration or by manually wiring a \"parameter_bag\" in the service locator passed to the controller. at /var/www/html/vendor/symfony/framework-bundle/Controller/AbstractController.php:68)"} []

Any idea what I'm doing wrong here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants