Close DB after each model generation #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each new app instance will open a new database connection, when generating a lot of models this causes a "Too many connections" error.
|
Thank you! |
handcode
added a commit
to handcode/yii2-giiant
that referenced
this pull request
Jul 20, 2022
…nnections' This patch fixes the 'too many connection' problem that was partially fixed in schmunk42#235 and schmunk42#276 but still exists if the application has other open DB connections in addition to the known modelDB.
handcode
added a commit
to handcode/yii2-giiant
that referenced
this pull request
Jul 20, 2022
This patch fixes the 'too many connection' problem that was partially fixed in schmunk42#235 and schmunk42#276 but still exists if the application has other open DB connections in addition to the known modelDB.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each new app instance will open a new database connection, when generating a lot of models this causes a "Too many connections" error.
This PR closes the database of the temp app before unloading it (which does not automatically closes the db connection).