Fix full width test #146
Merged
Fix full width test #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I appreciate that!! Its a great help. |
kodiakhq bot
referenced
this pull request
in cloudquery/cloudquery
Jan 1, 2023
…#6176) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/schollz/progressbar/v3](https://github.com/schollz/progressbar) | require | patch | `v3.12.1` -> `v3.12.2` | --- ### Release Notes <details> <summary>schollz/progressbar</summary> ### [`v3.12.2`](https://github.com/schollz/progressbar/releases/tag/v3.12.2) [Compare Source](https://github.com/schollz/progressbar/compare/v3.12.1...v3.12.2) #### What's Changed - Add minor fix for full width mode by [@​oerlikon](https://github.com/oerlikon) in [https://github.com/schollz/progressbar/pull/145](https://github.com/schollz/progressbar/pull/145) - Fix full width test by [@​oerlikon](https://github.com/oerlikon) in [https://github.com/schollz/progressbar/pull/146](https://github.com/schollz/progressbar/pull/146) **Full Changelog**: schollz/progressbar@v3.12.1...v3.12.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 3am on the first day of the month" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC40Mi4wIiwidXBkYXRlZEluVmVyIjoiMzQuNDIuMCJ9-->
kodiakhq bot
referenced
this pull request
in cloudquery/plugin-sdk
Jan 1, 2023
…#547) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/schollz/progressbar/v3](https://github.com/schollz/progressbar) | require | patch | `v3.12.1` -> `v3.12.2` | --- ### Release Notes <details> <summary>schollz/progressbar</summary> ### [`v3.12.2`](https://github.com/schollz/progressbar/releases/tag/v3.12.2) [Compare Source](https://github.com/schollz/progressbar/compare/v3.12.1...v3.12.2) #### What's Changed - Add minor fix for full width mode by [@​oerlikon](https://github.com/oerlikon) in [https://github.com/schollz/progressbar/pull/145](https://github.com/schollz/progressbar/pull/145) - Fix full width test by [@​oerlikon](https://github.com/oerlikon) in [https://github.com/schollz/progressbar/pull/146](https://github.com/schollz/progressbar/pull/146) **Full Changelog**: schollz/progressbar@v3.12.1...v3.12.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 3am on the first day of the month" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC40Mi4wIiwidXBkYXRlZEluVmVyIjoiMzQuNDIuMCJ9-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that when running
go test -bench.it handles stdout and stderr in some different way, soterm.GetSize()manages to get the actual size of the current terminal and cause TestOptionFullWidth to fail, so here is the fix.There was also another test that wasn't actually checking anything and I fixed that one as well.