Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Leedotype Global Background #156

Closed
wants to merge 2 commits into from

Conversation

hwoongkang
Copy link
Contributor

Leedotype Global Background was originally written in Objective-C, resulting in an error with apple silicon Macs.

Thus we rewrote it in Python to support more devices.

Changes:

  • Since it is rewritten in Python, we removed archs restriction
  • Changed "LT Global Background" to "LD Global Background"

@schriftgestalt
Copy link
Owner

I would strongly recommend to fix the objectiveC plugin instead if going back to python. It has a lot compatibility problems, too and is much slower.

@schriftgestalt
Copy link
Owner

And Changing the repo name and plugin name will make it very tedious for existing users to update. The updater is not capable of doing that, so everyone needs to remove and reinstall.

@hwoongkang
Copy link
Contributor Author

I couldn't find out how to fix the compile errors after changing to apple silicon Mac, and decided to migrate the plugin to Python. But since you strongly recommend remaining in Objective C, I guess I should look again for it.

Is there any trouble shooting guide regarding compilation (cross-compile, x86 and arm support, etc.) of Objective C SDK?

@schriftgestalt
Copy link
Owner

Can you add me to the objectiveC repo? I can have a look.

@hwoongkang
Copy link
Contributor Author

Oh that would be great. Thank you. I will add you and add a comment as soon as I finish tidying up the repository, since it has been a while I looked at the objectiveC version.

@hwoongkang
Copy link
Contributor Author

I think I figured it out. Sorry it took such a long time. I will make an another pull request.

@hwoongkang hwoongkang closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants