Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTL data-table #209

Closed
eafshary opened this issue Aug 19, 2017 · 7 comments · Fixed by #497
Closed

RTL data-table #209

eafshary opened this issue Aug 19, 2017 · 7 comments · Fixed by #497
Labels
documentation enhancement question

Comments

@eafshary
Copy link

How can I show data-table in rtl layout.
now column show from left to right
how can I change direction of columns and scrollbar?
@wcjordan
Copy link
Member

I haven't used the table in RTL mode but there is some code which changes things if Locale.isRTL returns true. You may want to explore playing with that.

https://github.com/schrodinger/fixed-data-table-2/search?utf8=%E2%9C%93&q=rtl&type=

@wcjordan
Copy link
Member

If you do find a good way to do it or what the current state of it is, let me know.

@eafshary
Copy link
Author

thanks, now table show from right to left but scrollbar shows on left and not working properly!
can change direction of scrollbar?

@wcjordan
Copy link
Member

That's as much as I know here. You'll likely need to dig into the code to fix up the issues.

@wcjordan wcjordan added the bug label Aug 20, 2017
@kamaldlk
Copy link

kamaldlk commented Feb 8, 2018 •
edited
Loading

How to use RTL in Fixed Data Table 2 please Help me on this

@kamaldlk
Copy link

kamaldlk commented Feb 8, 2018

@eafshary How to implement RTL In Table can you give me some example

@wcjordan wcjordan mentioned this issue Feb 9, 2018
Closed
@wcjordan wcjordan added enhancement and removed bug labels Feb 9, 2018
@louiebert louiebert mentioned this issue Oct 24, 2019
Merged
7 tasks
pradeepnschrodinger pushed a commit that referenced this issue Nov 28, 2019
@louiebert @pradeepnschrodinger
RTL Support (#497) (Fixes #209)
bb27bd2 
Adds new table prop `isRTL` that controls usage of RTL within FDT.

Flips interpretations of scroll/keyboard events and flips element positions on render. 
Thus app state is unchanged and callback props given to users will still report same values.
@pradeepnschrodinger
Copy link
Collaborator

Closing this as it got fixed through #497.

From v1.0.2 and onwards, the table prop isRTL can be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation enhancement question
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

RTL Support louiebert/fixed-data-table-2
4 participants
@wcjordan @eafshary @kamaldlk @pradeepnschrodinger