Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scoped enums for PyQt6 proper support #400

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jrom99
Copy link
Contributor

@jrom99 jrom99 commented Sep 24, 2024

Hello, I've updated each Qt enum so that they work both with PyQt5 and PyQt6 without any major hacking.

I also updated the INSTALL file to reflect changes to pip install . since pip23 and pip24, where all arguments must be in a key=value form. I took the liberty to change how some optional dependencies can be set/unset to be more explicit (--no-libxml is now --libxml=false), and as far as I've checked, they are not used in the current github workflow.

On Linux, Pymol has a dash/dock gear icon and WMCLASS "python3", I've fixed this so now it exports the correct WMCLASS (which for gnome means that it is now able to find the correct icon).

I couldn't find how to set PYMOL_PATH in a way that pip install . is able to listen:

  • Raises unknown argument error:
    • pip install . --config-settings pymol-path=/some/path
    • pip install . --config-settings pymol_path=/some/path
  • Ignored (pymol is placed in venvprefix/bin/pymol or pythonuserbase/bin/pymol):
    • PYMOL_PATH=/some/path/ pip install .
    • env PYMOL_PATH=/some/path/ pip install .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant