Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: fixed ssh key loading, removed support for specifying the ssh private key in plain text #88

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

MarshallAsch
Copy link
Contributor

Closes: #85
Closes: #84


Describe the pull request:

  • Removed support for specifying the content of the ssh key contents dirrectly, only private key file paths can be specified.
  • will no longer pass the ssh private key to wikish in plain text
  • will no longer copy the ssh private key to a temporary directory unless it needs to
  • will mount the ssh priate key into the docker container when running in docker

Checklist:

  • Verify that the changes work as expected
  • Verify that the changes work as expected when run using docker
  • Update documentation / not applicable
  • Update changelog / not applicable

@MarshallAsch MarshallAsch added breaking Breaking changes security security related changes type: bug Something isn't working labels Jul 26, 2022
@MarshallAsch MarshallAsch self-assigned this Jul 26, 2022
@MarshallAsch MarshallAsch merged commit 8c3bc79 into main Jul 26, 2022
@MarshallAsch MarshallAsch deleted the ssh-key-fix branch July 26, 2022 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking changes security security related changes type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] ssh key path only worked with public keys [BUG] ssh key does not accept absolute paths
1 participant