date-range Facet limit histogram is weird

[eddierubeiz]

1. Start here
2. Click Date in the faceting apparatus on the left
3. Type 1973 into the lower bound for dates
4. Click the apply button to limit dates.
5. The HTML is broken. Looks like malformed HTML.

[jrochkind]

oh man I ran into something similar that eventually went away, and I was never able to fix it.

Something is weird with the code that is using JS canvas to plot that graph, and deciding how wide the graph should be.

I am not sure why it doesn't occur on chf_sufia, but Blacklight's own CSS changed. It is hard to reproduce. I'm not sure if it is reproducible on stock latest Blacklight and blacklight_range_limit.

This may be a hard one to fix. blacklight_range_limit is some hacky stuff.

[jrochkind]

hmm, 1973 isn't a magic number though, seems to be happening with nearly anything. This is indeed bad. gah.

[eddierubeiz]

Yeah, this is generalized. I came across it working on my featured topics page.

[jrochkind]

Note could not be reproduced on Windows Chrome on 5th floor conference room.

i also noticed that clicking on the "Date" heading to collapse and then again to expand the date limit area -- gets it to be sized correctly again.

[HKativa]

Note: I did reproduce this bug on Windows Chrome on my office computer while testing Kithe on 10/30/2019.

[jrochkind]

Filed with blacklight_range_limit at projectblacklight/blacklight_range_limit#111

[HKativa]

Note in case this isn't a known issue: this error occurs when using the "limit dates" feature on the homepage as well.

Select "go" and you get:

[jrochkind]

Yep, it's going to happen on any page that is displaying a pre-chosen date limit. At least it can potentially happen on any such page; we know that it is a somewhat intermittent/unpredictable problem.

[jrochkind]

I'm currently not able to reproduce it, it no longer happens for me. Which makes it hard to tell if a change I've made fixes it or not, when I can no longer make it happen without the change.

@eddierubeiz @HKativa are you currently seeing it on your own machines?

[eddierubeiz]

I CANNOT reproduce it! It works for me in Safari and Chrome. As far as my browser is concerned... either you fixed it or it fixed itself.

[sanfordd]

Cannot reproduce on Chromium or Firefox looks fine for me.

[jrochkind]

It's just hard to reproduce, becuase it's basically a "race condition" that occurs depending on unpredictable timing of browser/network events. That we can't see it now doesn't mean it won't come back, but it does make it hard to work on, since it's hard to be sure if a code change fixed it when you can't reproduce it.