Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure label check runs on all PR push events / commits #22

Merged
merged 1 commit into from
Aug 19, 2023
Merged

Ensure label check runs on all PR push events / commits #22

merged 1 commit into from
Aug 19, 2023

Conversation

jarrodmillman
Copy link
Member

@jarrodmillman jarrodmillman added type: Documentation Improvements or additions to documentation type: Enhancement New feature or request labels Aug 18, 2023
@jarrodmillman jarrodmillman requested a review from stefanv August 18, 2023 16:32
@lagru
Copy link
Member

lagru commented Aug 18, 2023

See also numpy/numpydoc#493.

@lagru lagru changed the title Ensure label check runs on all commits Ensure label check runs on all PR push events / commits Aug 18, 2023
@stefanv stefanv merged commit 635d15f into scientific-python:main Aug 19, 2023
@jarrodmillman jarrodmillman added this to the 0.1 milestone Aug 19, 2023
@stefanv
Copy link
Member

stefanv commented Aug 19, 2023 •
edited
Loading

Thanks for helping us figure out all the subtleties here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larsoner larsoner larsoner left review comments

@lagru lagru lagru approved these changes

@stefanv stefanv Awaiting requested review from stefanv

Assignees
No one assigned
Labels
type: Documentation Improvements or additions to documentation type: Enhancement New feature or request
Projects
None yet
Milestone
0.1
Development

Successfully merging this pull request may close these issues.
4 participants
@jarrodmillman @lagru @stefanv @larsoner