Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove newlines between pull request summaries and their links #27

Merged
merged 1 commit into from
Sep 23, 2023

Conversation

lagru
Copy link
Member

@lagru lagru commented Sep 23, 2023

Fix #26.

cc @stefanv

@lagru lagru added the type: Enhancement New feature or request label Sep 23, 2023
@jarrodmillman jarrodmillman merged commit 63c4ca2 into scientific-python:main Sep 23, 2023
3 checks passed
@jarrodmillman jarrodmillman added this to the 0.1 milestone Sep 23, 2023
@lagru
Copy link
Member Author

lagru commented Sep 24, 2023

Did you notice that this was attached to the 0.1 milestone instead of the 0.2 one which I would have expected? Same with #28.

@lagru lagru deleted the remove-newlines branch September 24, 2023 09:33
@stefanv
Copy link
Member

stefanv commented Sep 24, 2023

I'll take a look. Thank action did determine 1 to be the next milestone:

https://github.com/scientific-python/changelist/actions/runs/6285659144/job/17068270627

@stefanv
Copy link
Member

stefanv commented Sep 24, 2023

0.1 was left open, that's why it was used. I closed it now.

@stefanv stefanv modified the milestones: 0.1, 0.2 Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markdown: PR list has newline before PR nr
3 participants