Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: fix pytest 8.0dev compatibility #213

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Aug 10, 2023

To fix #212 (which has more info and reference links)

@bsipocz bsipocz added this to the 1.0.0 milestone Aug 10, 2023
@bsipocz bsipocz requested a review from saimn August 10, 2023 00:24
Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff didn't show L519. I thought I was going crazy. Haha. Thanks!

But I won't merge yet in case you are waiting for Simon to review.

@bsipocz
Copy link
Member Author

bsipocz commented Aug 10, 2023

I only pinged him as he did the previous 7.0+ fix. But either case I'm about to head home and won't cut a release today so merging can wait.

@pllim
Copy link
Contributor

pllim commented Aug 10, 2023

He does know the code better than I do, so I'll leave it to y'all good judgement. Thanks!

Copy link
Contributor

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix is correct, thanks, and sorry for the breaking. 👍

@bsipocz bsipocz merged commit d671de0 into scientific-python:main Aug 10, 2023
@bsipocz bsipocz deleted the MAINT_fix_80dev branch December 13, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: incompatibility with pytest 8.0dev
3 participants