Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Remove python3.7 support #217

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Aug 22, 2023

No code changes, except a few very trivial touch-ups. However, there isn't much point develop future enhancements with python 3.7 in mind.

@bsipocz bsipocz added this to the 1.1.0 milestone Aug 22, 2023
Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But I do wonder if some of the existing Python 3.8 jobs should be bumped to 3.9+ but it is not really in scope here.

@bsipocz
Copy link
Member Author

bsipocz commented Aug 22, 2023

But I do wonder if some of the existing Python 3.8 jobs should be bumped to 3.9+ but it is not really in scope here.

I feel it doesn't really matter as those are somewhat redundant anyway, but I can bump them if you like.

@pllim
Copy link
Contributor

pllim commented Aug 22, 2023

Up to you. As I said, bumping those are out of scope, and I already approved. 😸

@bsipocz bsipocz merged commit 453a39b into scientific-python:main Aug 22, 2023
@bsipocz bsipocz deleted the MAINT_remove_py37 branch December 13, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants