BUG: Fix module level import requires #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the logic was written in a negate way compared to the normal skipping, the module level skip didn't take into account the special "*" and "." patterns. scientific-pythongh-109 probably misdiagnosed the module actually missing only on the run the had pytest-xdist: the test does not seem to ever pass either way. Closes scientific-pythongh-109
While `pass` if statements are not always great, I think this is a bit closer to what it was and probably easier to grock when compared to the code above it.
bsipocz
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the logic was written in a negate way compared to the normal skipping, the module level skip didn't take into account the special "*" and "." patterns.
gh-109 probably misdiagnosed the module actually missing only on the run the had pytest-xdist: the test does not seem to ever pass either way.
Closes gh-109