Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add external link icon #162

Merged
merged 1 commit into from
Mar 22, 2022
Merged

Conversation

jarrodmillman
Copy link
Member

@jarrodmillman jarrodmillman commented Mar 22, 2022

Close #161. Uses https://materialui.co/icon/launch .

We need to

  • update layouts/partials/navbar.html to use the launch icon when the value of the url in
  navbar:
    - title:
      url:

from the config.yaml starts with http or something.

@netlify
Copy link

netlify bot commented Mar 22, 2022

✅ Deploy Preview for scientific-python-hugo-theme ready!

🔨 Explore the source changes: c3952c0

🔍 Inspect the deploy log: https://app.netlify.com/sites/scientific-python-hugo-theme/deploys/6239527d8997c70008669fab

😎 Browse the preview: https://deploy-preview-162--scientific-python-hugo-theme.netlify.app/reports/lighthouse

@jarrodmillman jarrodmillman marked this pull request as draft March 22, 2022 04:40
@stefanv stefanv marked this pull request as ready for review March 22, 2022 06:20
@stefanv stefanv merged commit 475343a into scientific-python:main Mar 22, 2022
@jarrodmillman jarrodmillman added this to the 0.1 milestone Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

External links
2 participants