Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Spacing around notice boxes #255

Merged

Conversation

alphapapa
Copy link
Contributor

  • assets/theme-css/notices.css:
    (.notice): Set top/bottom margins to 1em.

  • layouts/shortcodes/notice.html: Remove <br>.

Fixes #254.

After this change:
notice-after

* assets/theme-css/notices.css:
(.notice): Set top/bottom margins to 1em.

* layouts/shortcodes/notice.html: Remove <br>.

Fixes <scientific-python#254>.
@netlify
Copy link

netlify bot commented Aug 24, 2023

Deploy Preview for scientific-python-hugo-theme ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit dd1bd89
🔍 Latest deploy log https://app.netlify.com/sites/scientific-python-hugo-theme/deploys/64e793a6415d790007110d20
😎 Deploy Preview https://deploy-preview-255--scientific-python-hugo-theme.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jarrodmillman jarrodmillman merged commit 40be044 into scientific-python:main Aug 25, 2023
5 checks passed
@jarrodmillman jarrodmillman modified the milestone: 0.1 Sep 29, 2023
@alphapapa alphapapa deleted the wip/254-notice-spacing branch October 16, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: Bug fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.notice / .mission-notice DIVs have inconsistent spacing
2 participants