-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PDST assets #634
Update PDST assets #634
Conversation
✅ Deploy Preview for scientific-python-hugo-theme ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
I had been avoiding importing files we aren't using. |
I can take those out; this was to test visual changes, to ensure we don't have too big a jump next time we do an ugprade. |
a0e649a
to
844f775
Compare
Removed unused files. Applied different fix for missing variable, in response to pydata/pydata-sphinx-theme#1953 |
@@ -1,3 +1,9 @@ | |||
// Next line added by SPHT, to add missing bootstrap-provided variables |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been adding things like this to the bottom of assets/theme-css/styles.css
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My plan was to factor #pst-back-to-top
out of base/_base.scss
and into something like base/_back_to_top.scss
or something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just keep commenting out // z-index: $zindex-tooltip;
like we are currently doing and then factor out the styling we don't need from base/_base.scss
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought the less editing of the original sources needed, the easier it would be to stay in sync.
No description provided.