fix(make): use global image tag env

Signed-off-by: Cameron Smith <cameron.ray.smith@gmail.com>
sciexp · Nov 25, 2023 · d0a1075 · d0a1075
1 parent 1d05c85
commit d0a1075
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/.example.env b/.example.env
@@ -15,6 +15,7 @@ WORKFLOW_NAME=example.training_workflow
 # WORKFLOW_VERSION="d5ee0e4" # override auto version
 # WORKFLOW_IMAGE="ghcr.io/flyteorg/flytekit:py3.10-1.10.0" # upstream
 WORKFLOW_IMAGE="ghcr.io/repo/image:tag"
+GLOBAL_IMAGE_TAG=latest
 WORKFLOW_OUTPUT_FORMAT=dot
 FLYTE_CLUSTER_ENDPOINT=dns:///cluster.net
 GCP_PROJECT_ID=project-111111

diff --git a/Makefile b/Makefile
@@ -159,8 +159,8 @@ docker_login: ## Login to ghcr docker registry. Check regcreds in $HOME/.docker/
 	docker login ghcr.io -u $(GH_ORG) -p $(GITHUB_TOKEN)
 
 tag_images: ## Tag latest docker images.
-	crane tag $(WORKFLOW_IMAGE):$(WORKFLOW_IMAGE_TAG) latest
-	crane tag ghcr.io/$(GH_ORG)/$(GH_REPO):$(WORKFLOW_IMAGE_TAG) latest
+	crane tag $(WORKFLOW_IMAGE):$(WORKFLOW_IMAGE_TAG) $(GLOBAL_IMAGE_TAG)
+	crane tag ghcr.io/$(GH_ORG)/$(GH_REPO):$(WORKFLOW_IMAGE_TAG) $(GLOBAL_IMAGE_TAG)
 
 #-------------
 # system / dev