[TO-REVIEW] Add multi-domain Monge alignment and JCPOT Target shift method #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rflamary
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #180 +/- ##
==========================================
+ Coverage 97.01% 97.02% +0.01%
==========================================
Files 54 54
Lines 5319 5419 +100
==========================================
+ Hits 5160 5258 +98
- Misses 159 161 +2 |
kachayev
reviewed
Apr 30, 2024
| # %% Multisource and taregt data | ||
|
|
||
|
|
||
| def get_multidomain_data( |
There was a problem hiding this comment.
This should go to toy datasets, right?
kachayev
reviewed
Apr 30, 2024
kachayev
reviewed
Apr 30, 2024
skada/_mapping.py
Outdated
| ------- | ||
| X_t : array-like, shape (n_samples, n_components) | ||
| The data transformed to the target subspace. | ||
| y_t : array-like, shape (n_samples,) |
There was a problem hiding this comment.
Only X_adapt is returned.
kachayev
reviewed
Apr 30, 2024
|
|
||
| check_consistent_length(arrays) | ||
|
|
||
| domain_idx = extract_domains_indices(sample_domain, False) |
There was a problem hiding this comment.
We need to make boolean into a (forced-)named argument (I guess not the part of this PR)
rflamary
changed the title
rflamary
changed the title
rflamary
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a multi domain Monge alignement Adapter to SKADA that does the following
Also implement the multisource JCPOT taregt shift method (that should also work for only one source)
Remain to be done